Merge pull request #106 from samuel-esp/timeout

New Feature: Introduced An Argument To Customize Timeout When Contacting API Server

README.md

@@ -457,6 +457,13 @@ Supported Admission Controllers are
 > Make sure to read the [Scaling Jobs With Admission Controller](#scaling-jobs-with-admission-controller) section
 > to understand how to use the `--admission-controller` feature correctly
 
+`--api-server-timeout`
+
+: Optional: This is an advanced option that allows setting a timeout duration for all
+calls made by Kube Downscaler to the Kubernetes API Server. It can only take integer values
+(default: 10). This setting should only be added to Kube Downscaler arguments if timeout 
+issues are observed in the logs.
+
 ### Constrained Mode (Limited Access Mode)
 
 The Constrained Mode (also known as Limited Access Mode) is designed for users who do not have full cluster access.

kube_downscaler/cmd.py

@@ -66,6 +66,12 @@ def get_parser():
         help="Grace period in seconds for deployments before scaling down (default: 15min)",
         default=os.getenv("GRACE_PERIOD", 900),
     )
+    parser.add_argument(
+        "--api-server-timeout",
+        type=int,
+        help="Timeout to be used when kubedownscaler performs call to the Kubernetes API Server (default: 10s)",
+        default=os.getenv("API_SERVER_TIMEOUT", 10),
+    )
     upscale_group.add_argument(
         "--upscale-period",
         help="Default time period to scale up once (default: never)",

kube_downscaler/main.py

@@ -42,6 +42,7 @@ def main(args=None):
         args.interval,
         args.upscale_target_only,
         args.dry_run,
+        args.api_server_timeout,
         args.downtime_replicas,
         args.deployment_time_annotation,
         args.enable_events,
@@ -64,6 +65,7 @@ def run_loop(
     interval,
     upscale_target_only,
     dry_run,
+    api_server_timeout,
     downtime_replicas,
     deployment_time_annotation=None,
     enable_events=False,
@@ -99,6 +101,7 @@ def run_loop(
                 grace_period=grace_period,
                 admission_controller=admission_controller,
                 constrained_downscaler=constrained_downscaler,
+                api_server_timeout=api_server_timeout,
                 downtime_replicas=downtime_replicas,
                 deployment_time_annotation=deployment_time_annotation,
                 enable_events=enable_events,

kube_downscaler/scaler.py

@@ -1351,6 +1351,7 @@ def scale(
     grace_period: int,
     admission_controller: str,
     constrained_downscaler: bool,
+    api_server_timeout: int,
     downtime_replicas: int = 0,
     deployment_time_annotation: Optional[str] = None,
     enable_events: bool = False,
@@ -1360,6 +1361,7 @@ def scale(
 
     now = datetime.datetime.now(datetime.timezone.utc)
     forced_uptime = pods_force_uptime(api, namespaces)
+    pykube.http.DEFAULT_HTTP_TIMEOUT=api_server_timeout
 
     for clazz in RESOURCE_CLASSES:
         plural = clazz.endpoint

pyproject.toml

@@ -7,7 +7,7 @@ authors = ["Henning Jacobs <[email protected]>"]
 
 [tool.poetry.dependencies]
 python = ">=3.8,<4"
-new-pykube = "^24.7.0"
+new-pykube = "^24.10.0"
 pytz = "*"
 
 [tool.poetry.dev-dependencies]