Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: poetry command #133

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix: poetry command #133

merged 1 commit into from
Feb 26, 2025

Conversation

JTaeuber
Copy link
Member

Motivation

Apparently we still need --no-root ¯\_(ツ)_/¯

Changes

  • Added --no-root to poetry command

TODO

  • I've assigned myself to this PR

@JTaeuber JTaeuber added the bug Something isn't working label Feb 26, 2025
@JTaeuber JTaeuber self-assigned this Feb 26, 2025
jonathan-mayer
jonathan-mayer approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@jonathan-mayer jonathan-mayer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLIWWTM

@github-actions GitHub Actions
Copy link

File Coverage
All files 97% ✅
test_autoscale_resource.py 99% ✅
test_cmd.py 100% ✅
test_events.py 100% ✅
test_grace_period.py 100% ✅
test_ignore_if_labels_dont_match.py 100% ✅
test_main.py 100% ✅
test_pods_force_uptime.py 100% ✅
test_resources.py 100% ✅
test_scaler.py 95% ✅
test_time.py 100% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against a51076a

samuel-esp
samuel-esp approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@samuel-esp samuel-esp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JTaeuber JTaeuber merged commit 33a0b2e into main Feb 26, 2025
5 checks passed
@JTaeuber JTaeuber deleted the fix/PoetryCommand branch February 26, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-esp samuel-esp samuel-esp approved these changes

@jonathan-mayer jonathan-mayer jonathan-mayer approved these changes

@Fovty Fovty Awaiting requested review from Fovty Fovty is a code owner

Assignees

@JTaeuber JTaeuber

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JTaeuber @samuel-esp @jonathan-mayer