Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/dispatch-event #23

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Feat/dispatch-event #23

merged 3 commits into from
Apr 17, 2024

Conversation

Fovty
Copy link
Member

@Fovty Fovty commented Apr 17, 2024 •
edited
Loading

Motivation

This PR introduces an automated workflow to manage Helm chart packaging and distribution across the py-kube-downscaler and helm-charts repositories. The aim is to automate updates and deployment processes.

Changes

  • py-kube-downscaler Repository:
    • Automated Helm chart packaging and pushing to GHCR upon new tag creation.
    • Dispatch event triggered to notify the helm-charts repository.

References

TODO

  • Assign myself to this PR.
  • Save PAT in secrets.
  • Merge this PR after final approvals.

@Fovty Fovty self-assigned this Apr 17, 2024
@Fovty Fovty added feature enhancement New feature or request and removed feature labels Apr 17, 2024
@Fovty Fovty requested a review from eumel8 April 17, 2024 14:02
@Fovty Fovty changed the title Feat/dispatch event Feat/dispatch-event Apr 17, 2024
@eumel8
add missing var
3389eba 
Signed-off-by: Frank Kloeker <[email protected]>
eumel8
eumel8 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@eumel8 eumel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with 0.1.0 tag

JTaeuber
JTaeuber approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@JTaeuber JTaeuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fovty Fovty merged commit 62b4bd0 into main Apr 17, 2024
8 checks passed
@Fovty Fovty deleted the feat/dispatch-event branch April 17, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eumel8 eumel8 eumel8 approved these changes

@JTaeuber JTaeuber JTaeuber approved these changes

@jonathan-mayer jonathan-mayer Awaiting requested review from jonathan-mayer jonathan-mayer is a code owner

Assignees

@Fovty Fovty

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fovty @eumel8 @JTaeuber