Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add necessary build tools & dependencies #45

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

Fovty
Copy link
Member

@Fovty Fovty commented May 21, 2024

Motivation

This change addresses the build failure issue introduced in PR #39, where the transition to the python:3.10-alpine3.19 base image resulted in missing build tools necessary for compiling certain Python packages. The failed pipeline can be viewed here. This update ensures that the necessary build dependencies are installed, allowing the pipeline to complete successfully. The successful pipeline build after the fix can be viewed here.

Changes

  • Added installation of build tools (gcc, musl-dev, libffi-dev, python3-dev, py3-setuptools) to the Dockerfile before installing poetry.

Tests done

  • Verified that the Docker image builds successfully without errors.
  • Ensured the pipeline runs to completion, confirming the fix.

TODO

  • I've assigned myself to this PR

@Fovty Fovty self-assigned this May 21, 2024
@Fovty Fovty added the fix label May 21, 2024
@JTaeuber JTaeuber merged commit b718d29 into main May 21, 2024
4 checks passed
@JTaeuber JTaeuber deleted the fix/build-workflow branch May 21, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants