Propagate Tracer when building TChannel#1042
Propagate Tracer when building TChannel#1042natemort merged 1 commit intocadence-workflow:v3.13.xfrom
Conversation
abhishekj720
left a comment
There was a problem hiding this comment.
Overall LGTM with a minor comment about explanation of reason of downgrading opentracing-mock
| testCompile group: 'ch.qos.logback', name: 'logback-classic', version: '1.2.3' | ||
| testCompile group: 'io.grpc', name: 'grpc-testing', version: '1.54.2' | ||
| testImplementation 'io.opentracing:opentracing-mock:0.33.0' | ||
| testImplementation 'io.opentracing:opentracing-mock:0.32.0' |
There was a problem hiding this comment.
why opentracing-mock is pinned to 0.32.0 (what conflict it avoids)?
There was a problem hiding this comment.
The TChannel version we're using at runtime uses the opentracing 0.32.0 core libraries. This test dependency ends up overwriting that, making our tests run against opentracing 0.33.0 core.
There was a breaking change in opentracing, so the tests all fail after the Tracer is added because the method they call no longer exists.
This change corrects the test version to match what we actually run against. It's a test dependency of the java client, so it doesn't impact users at all.
a4d5574 to
46a97c5
Compare
46a97c5 to
5a11942
Compare
While workflows still capture the tracing information in the headers, we should pass the Tracer to TChannel so that we correctly trace all RPC requests sent to the Cadence server. Ensure that Tracer can't be set to null and correct the testing library version to avoid classpath conflicts.
5a11942 to
308ddb8
Compare
While workflows still capture the tracing information in the headers, we should pass the Tracer to TChannel so that we correctly trace all RPC requests sent to the Cadence server.
Ensure that Tracer can't be set to null and correct the testing library version to avoid classpath conflicts.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes