Skip to content

Independent Simple JSON Viewer #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

apsrcreatix
Copy link

Hi @cakeinpanic

I have removed the dependency of Axios and classnames from the repository and improved styling. The logic behind the application is the same as it was. I wanted to create an independent simple JSON viewer in Reactjs and found your code.

Thanks!

Copy link
Owner

@cakeinpanic cakeinpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for soooooo long answer :)
Thank you for your work!

But this PR is huge and its is very hard to understand if initial code logic is really remaining the same, cause all the files are deleted and new ones created.
Can you please(if you are still interested) prepare atomic prs? One for axios, one for styling

@apsrcreatix
Copy link
Author

I have not changed much of code just refractor a few things and structured a little bit. You can check the functioning of the changes made in this link -> https://simple-json-viewer.netlify.com/

Thank you so much for your response but currently, I am busy with some other work so I can't do the splitting of the pull request. But if I get time any day then I will surely look back to do this!

Best Regards,
Aditya Pratap Singh Rajput

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants