Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: introduce admin conftest to use for testing add permissions #2659

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

angela-tran
Copy link
Member

This PR extracts out the conftest.py from #2654. This is so other PRs can be worked on to add and test the add permissions for ClaimsProvider and TransitAgency without having to wait for #2654.

Some guidance for the other PRs:

  • Continue using model_AdminUser. We can look into switching to admin_user as a separate PR after these PRs that add the permissions.
  • No need to add or test any "regular" user scenarios

@angela-tran angela-tran self-assigned this Feb 3, 2025
@angela-tran angela-tran requested a review from a team as a code owner February 3, 2025 18:24
@github-actions github-actions bot added the tests Related to automated testing (unit, UI, integration, etc.) label Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@angela-tran angela-tran merged commit 3cf78db into main Feb 3, 2025
16 checks passed
@angela-tran angela-tran deleted the chore/admin-conftest branch February 3, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants