Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate user booking pages to App Router #19069

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: migrate user booking pages to App Router #19069

wants to merge 8 commits into from
+139 −151

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Feb 3, 2025 •
edited
Loading

What does this PR do?

  • Migrate user booking pages to App Router (/[user] and /[user]/[type])

Tested

Screenshot 2025-02-03 at 4 43 32 PM Screenshot 2025-02-03 at 4 44 08 PM Screenshot 2025-02-03 at 4 43 46 PM Screenshot 2025-02-03 at 4 45 36 PM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Test /[user] and /[user]/[type] pages

@hbjORbj hbjORbj marked this pull request as draft February 3, 2025 21:12
@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 3, 2025
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Feb 3, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:39am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 5:39am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 5:39am

@hbjORbj hbjORbj requested review from a team February 3, 2025 21:12
@hbjORbj hbjORbj changed the title chore: migrate user booking pages chore: migrate user booking pages to App Router Feb 3, 2025
@hbjORbj hbjORbj marked this pull request as ready for review February 3, 2025 21:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

E2E results are ready!

@hbjORbj hbjORbj added high-risk Requires approval by Foundation team ready-for-e2e and removed ready-for-e2e labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeauyeung joeauyeung joeauyeung approved these changes

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking consumer core area: core, team members only high-risk Requires approval by Foundation team ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @joeauyeung @keithwillcode