-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip confirm step followup #19076
base: main
Are you sure you want to change the base?
Conversation
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/04/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (02/04/25)1 reviewer was added to this PR based on Keith Williams's automation. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
E2E results are ready! |
What does this PR do?
This PR fixes two key issues in the Booker flow when skipping the confirmation step:
Ensuring Users Are Notified of Submission Errors
Fixing the Double Click Issue on the Confirm Button
Before, users had to click the Confirm button twice in the Booker Atom for the submission to proceed.
This PR resolves the issue, ensuring a single click properly triggers the submission.
before: https://github.com/user-attachments/assets/d3d5909b-469b-4802-94be-5d0eac408ece
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist