Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip confirm step followup #19076

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Feb 4, 2025

What does this PR do?

This PR fixes two key issues in the Booker flow when skipping the confirmation step:

  1. Ensuring Users Are Notified of Submission Errors

  2. Fixing the Double Click Issue on the Confirm Button

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team February 4, 2025 09:44
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Followup/skip confirm step". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Feb 4, 2025
@graphite-app graphite-app bot requested a review from a team February 4, 2025 09:45
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking consumer labels Feb 4, 2025
Copy link

graphite-app bot commented Feb 4, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/04/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (02/04/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@SomayChauhan SomayChauhan changed the title Followup/skip confirm step fix: skip confirm step followup Feb 4, 2025
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 10:24am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 10:24am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 10:24am

Copy link
Contributor

github-actions bot commented Feb 4, 2025

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking consumer core area: core, team members only platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants