Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate api for team creation to App Router #19105

Merged
merged 2 commits into from
Feb 6, 2025
Merged

chore: migrate api for team creation to App Router #19105

merged 2 commits into from
Feb 6, 2025

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Feb 5, 2025 •
edited
Loading

What does this PR do?

  • Migrates /api/teams/create.ts to App Router

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Try creating a team and check Network Tab to see the api request

@graphite-app graphite-app bot requested a review from a team February 5, 2025 01:59
@hbjORbj hbjORbj changed the title chore: migrate api team create chore: migrate api for team creation to App Router Feb 5, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 10:35am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 10:35am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 10:35am

@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 5, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/05/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (02/05/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth teams area: teams, round robin, collective, managed event-types labels Feb 5, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 5, 2025
@hbjORbj hbjORbj added high-risk Requires approval by Foundation team and removed ready-for-e2e labels Feb 5, 2025
@hbjORbj hbjORbj marked this pull request as draft February 5, 2025 02:28
@graphite-app graphite-app bot requested a review from a team February 5, 2025 02:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025 •
edited
Loading

E2E results are ready!

@hbjORbj hbjORbj marked this pull request as ready for review February 6, 2025 10:26
@eunjae-lee
Copy link
Contributor

eunjae-lee commented Feb 6, 2025 •
edited
Loading

the actual changes for anyone interested

Screenshot.2025-02-06.at.11.40.11.mp4

@hbjORbj hbjORbj removed the high-risk Requires approval by Foundation team label Feb 6, 2025
@hbjORbj hbjORbj removed the request for review from a team February 6, 2025 20:48
@hbjORbj hbjORbj merged commit 239c8a6 into main Feb 6, 2025
43 checks passed
@hbjORbj hbjORbj deleted the chore/migrate-api-team-create branch February 6, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunjae-lee eunjae-lee eunjae-lee approved these changes

Assignees
No one assigned
Labels
api area: API, enterprise API, access token, OAuth consumer core area: core, team members only ready-for-e2e teams area: teams, round robin, collective, managed event-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @eunjae-lee @keithwillcode