Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tech debt clearing — remove BookerSeo from user type booking pages #19145

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Feb 6, 2025

What does this PR do?

  • BookerSeo component is not needed in user type booking client component because user type booking pages are in App Router and hence metadata is handled by App Router natively.
  • There are some embeds still in Pages Router that use this client component, but embeds do not need SEO, so this is ok

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Go to a user type booking page and check header element to see metadata.

@graphite-app graphite-app bot requested a review from a team February 6, 2025 23:25
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 11:32pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Feb 6, 2025 11:32pm
calcom-web-canary ⬜️ Ignored (Inspect) Feb 6, 2025 11:32pm

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 6, 2025
@hbjORbj hbjORbj changed the title chore: tech debt clearing remove bookerseo from user type public view chore: tech debt clearing — remove BookerSeo from user type booking pages Feb 6, 2025
@hbjORbj hbjORbj enabled auto-merge (squash) February 6, 2025 23:27
Copy link

graphite-app bot commented Feb 6, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

E2E results are ready!

@hbjORbj hbjORbj closed this Feb 7, 2025
auto-merge was automatically disabled February 7, 2025 00:01

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants