Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor apiRouteMiddleware and add it to some api routes in App Router #19146

Merged
merged 4 commits into from
Feb 7, 2025
Merged

chore: refactor apiRouteMiddleware and add it to some api routes in App Router #19146

merged 4 commits into from
Feb 7, 2025
+132 −161

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Feb 6, 2025 •
edited
Loading

What does this PR do?

  • refactor apiRouteMiddleware and add it to some api routes in App Router

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 6, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 0:31am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:31am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 0:31am

@dosubot dosubot bot added the api area: API, enterprise API, access token, OAuth label Feb 6, 2025
@graphite-app graphite-app bot requested a review from a team February 6, 2025 23:42
@hbjORbj hbjORbj force-pushed the chore/remove-try-and-catch-from-api-routes branch from c865754 to 10503fd Compare February 6, 2025 23:43
@hbjORbj hbjORbj changed the title chore: remove try and catch from api routes chore: remove try and catch from api routes in app router Feb 6, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 6, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj mentioned this pull request Feb 6, 2025
Merged
3 tasks
@hbjORbj hbjORbj changed the title chore: remove try and catch from api routes in app router chore: ensure app router api routes errors get logged to Sentry Feb 6, 2025
@hbjORbj hbjORbj marked this pull request as draft February 6, 2025 23:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025 •
edited
Loading

E2E results are ready!

@hbjORbj hbjORbj changed the title chore: ensure app router api routes errors get logged to Sentry chore: refactor apiRouteMiddleware Feb 7, 2025
@hbjORbj hbjORbj changed the title chore: refactor apiRouteMiddleware chore: refactor apiRouteMiddleware and add it to some api routes in App Router Feb 7, 2025
@hbjORbj hbjORbj marked this pull request as ready for review February 7, 2025 00:48
@dosubot dosubot bot added the 💻 refactor label Feb 7, 2025
@hbjORbj hbjORbj enabled auto-merge (squash) February 7, 2025 00:55
emrysal
emrysal approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hbjORbj hbjORbj merged commit e79af63 into main Feb 7, 2025
85 of 88 checks passed
@hbjORbj hbjORbj deleted the chore/remove-try-and-catch-from-api-routes branch February 7, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

Assignees
No one assigned
Labels
api area: API, enterprise API, access token, OAuth consumer core area: core, team members only ready-for-e2e 💻 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @emrysal @keithwillcode