chore: tech debt clearing — remove HeadSeo from components where not needed #19151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
hbjORbj
changed the title
hbjORbj
changed the title
hbjORbj
commented
Feb 7, 2025
| @@ -337,7 +327,6 @@ export default function Signup({ | |||
| "[--cal-brand-emphasis:#101010] dark:[--cal-brand-emphasis:#e1e1e1] " | |||
| )}> | |||
| <div className="bg-muted 2xl:border-subtle grid w-full max-w-[1440px] grid-cols-1 grid-rows-1 overflow-hidden lg:grid-cols-2 2xl:rounded-[20px] 2xl:border 2xl:py-6"> | |||
| <HeadSeo title={t("sign_up")} description={t("sign_up")} /> | |||
There was a problem hiding this comment.
app/signup/page.tsx has generateMetadata replacing this
hbjORbj
commented
Feb 7, 2025
| @@ -14,11 +13,6 @@ const ShellHeading = () => { | |||
| export default function WrappedApp(props: AppPageProps) { | |||
| return ( | |||
| <Shell smallHeading isPublic hideHeadingOnMobile heading={<ShellHeading />} backPath="/apps" withoutSeo> | |||
| <HeadSeo | |||
There was a problem hiding this comment.
app/apps/[slug]/page.tsx has generateMetadata replacing this
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/07/25)1 reviewer was added to this PR based on Keith Williams's automation. |
joeauyeung
previously approved these changes
Feb 7, 2025
hbjORbj
force-pushed
the
chore/tech-debt-clearing-remove-headseo-from-apps-page
branch
from
0e218d3 to
981b8e0
Compare
joeauyeung
approved these changes
Feb 7, 2025
hbjORbj
deleted the
chore/tech-debt-clearing-remove-headseo-from-apps-page
branch
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
HeadSeofor pages already migrated to App Router (we don't need it because in App RoutergenerateMetadatahandles it)Mandatory Tasks (DO NOT REMOVE)