-
Notifications
You must be signed in to change notification settings - Fork 11.1k
fix: calendar events not syncing with v2 api bookings #25053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes calcom#25009 ### Issue Summary **API v2 POST /bookings creates ACCEPTED bookings but fails to sync to calendar or send emails - Regression of calcom#16512** When creating bookings via the Cal.com API v2 (`POST /v2/bookings`), bookings are successfully created with `status: "ACCEPTED"` and show on the Cal.com dashboard, but they **do not sync to the connected calendar** (Google Calendar/Outlook) and **no confirmation emails are sent** to attendees or hosts. The API response shows an empty `references: []` array, indicating Cal.com failed to create the actual calendar event despite having a valid `destinationCalendarId`. This appears to be a regression or incomplete fix of Issue calcom#16512
|
@a-tokyo is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
dhairyashiil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please attach before and after loom video, making it draft until then.
|
Going with this one:- #25049 🙏 |
Closes #25009
Issue Summary
API v2 POST /bookings creates ACCEPTED bookings but fails to sync to calendar or send emails - Regression of #16512
When creating bookings via the Cal.com API v2 (
POST /v2/bookings), bookings were created successfully withstatus: "ACCEPTED"and appeared on the dashboard, but did not sync to the connected calendar (Google/Outlook) and no confirmation emails were sent.The API response contained an empty
references: []array, indicating that no calendar event was created.What does this PR do?
Summary of changes:
areCalendarEventsEnabled: trueflag when creating new requests from the API.Files changed:
apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.tsVisual Demo
Before:
After:
Mandatory Tasks
How should this be tested?
POST /v2/bookingsrequest with a valid booking payload.ACCEPTEDreferencesExpected:
Calendar sync and email notifications now function correctly for API v2 bookings.