-
Notifications
You must be signed in to change notification settings - Fork 11.1k
feat: add hashedLink to BOOKING_REQUEST/CREATED webhooks payload via RegularBookingService #25274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hashedLink to BOOKING_REQUEST/CREATED webhooks payload via RegularBookingService #25274
Conversation
- Add hashedLink field to CalendarEvent type definition - Add withHashedLink method to CalendarEventBuilder - Pass hashedLink from booking request to CalendarEvent in RegularBookingService - hashedLink will now be included in webhook payloads when booking via private API links Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
E2E results are ready! |
- Add hashedLink field to CalendarEvent type definition - Add withHashedLink method to CalendarEventBuilder - Pass hashedLink from booking request to CalendarEvent in RegularBookingService - hashedLink will now be included in webhook payloads when booking via private API links Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
What does this PR do?
This PR adds the
hashedLinkfield to theBOOKING_webhooks payload, allowing webhook consumers to identify when a booking was made via a private link and which specific link was used.Changes:
hashedLinkfield to theCalendarEventtype definitionwithHashedLink()method toCalendarEventBuilderfor setting the hashedLinkRegularBookingServiceto pass the hashedLink from the booking request to the CalendarEventThe hashedLink is automatically included in webhook payloads via the existing spread operator in
getWebhookPayloadForBooking, which spreads the entireCalendarEventobject into the payload.Link to Devin run: https://app.devin.ai/sessions/97d690b2c1ae4f5895daa06bd8f5a32e
Requested by: [email protected] (@ThyMinimalDev)
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
/d/{hashedLink}/{eventSlug})BOOKING_REQUESTEDeventshashedLinkfield with the correct link token valuehashedLinkasnullor undefinedExpected behavior:
hashedLinkshould contain the link token (e.g., "sgdthj8mu4nsLNTYi3fW2p")hashedLinkshould benullor undefinedImportant Review Points
hashedLinkactually appears in the webhook payload by tracing throughgetWebhookPayloadForBooking→ webhook deliveryhasHashedBookingLink ? reqBody.hashedLink ?? null : nullcorrectly identifies private link bookings