chore: No more clientside markdown when importing Checkbox #25278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| )} | ||
| dangerouslySetInnerHTML={{ | ||
| __html: markdownToSafeHTML(descriptionAsSafeHtml), | ||
| __html: descriptionAsSafeHtml, |
Member
There was a problem hiding this comment.
Are we sure we have already converted markdown to html at this point
Contributor
Author
There was a problem hiding this comment.
Yes, this prop is only used in one place, which has already converted markdown to html - form builder.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
hariombalhara
approved these changes
Nov 19, 2025
Member
hariombalhara
left a comment
hariombalhara
left a comment
There was a problem hiding this comment.
@hariombalhara approved this PR from Slack with Graphite
Contributor
E2E results are ready! |
keithwillcode
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Checkbox no longer converts markdown on the client; it renders pre-sanitized HTML (descriptionAsSafeHtml) directly. This reduces bundle size and improves performance.
Written for commit 7d504ab. Summary will update automatically on new commits.