Skip to content

Conversation

@ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Nov 21, 2025

Fixing SMS not being triggered via apiv2 because of how IS_E2E is treated on API v2


Summary by cubic

Enables SMS sending in API v2 by fixing E2E test-mode detection in the Twilio provider. Test mode now only activates when IS_E2E is exactly "true", preventing accidental suppression of real SMS.

  • Bug Fixes
    • Added IS_API_V2_E2E constant and used it in Twilio provider.
    • Prevented test mode from enabling when IS_E2E="false", restoring SMS delivery in API v2.

Written for commit 37b065c. Summary will update automatically on new commits.

@vercel
Copy link

vercel bot commented Nov 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
cal-eu Ignored Ignored Nov 21, 2025 0:45am

@graphite-app graphite-app bot requested review from a team November 21, 2025 12:46
@keithwillcode keithwillcode added core area: core, team members only foundation platform Anything related to our platform plan labels Nov 21, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@github-actions
Copy link
Contributor

E2E results are ready!

@emrysal emrysal merged commit 6499243 into main Nov 21, 2025
81 of 87 checks passed
@emrysal emrysal deleted the fix-enable-sms-api-v2 branch November 21, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only foundation platform Anything related to our platform plan ready-for-e2e size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants