Skip to content

fix: meeting ended page server component dto #25318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2025
Merged

fix: meeting ended page server component dto #25318

merged 2 commits into from
Nov 21, 2025
+9 −16

Conversation

@ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Nov 21, 2025 •
edited
Loading

What does this PR do?

ensure meeting ended getServerSideProps only fetches and display the required data and nothing else

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@graphite-app graphite-app bot requested review from a team November 21, 2025 14:06
@keithwillcode keithwillcode added core area: core, team members only foundation platform Anything related to our platform plan labels Nov 21, 2025
@vercel
Copy link

vercel bot commented Nov 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Nov 21, 2025 2:08pm
cal-eu Ignored Ignored Nov 21, 2025 2:08pm

@keithwillcode keithwillcode enabled auto-merge (squash) November 21, 2025 14:12
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@keithwillcode keithwillcode merged commit 0af6354 into main Nov 21, 2025
67 of 72 checks passed
@keithwillcode keithwillcode deleted the fix-meeting-ended-server-component-dto branch November 21, 2025 15:29
@keithwillcode keithwillcode added this to the v6.0 milestone Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@emrysal emrysal emrysal approved these changes

@keithwillcode keithwillcode keithwillcode approved these changes

Assignees

No one assigned

Labels

core area: core, team members only foundation platform Anything related to our platform plan ready-for-e2e size/S

Projects

None yet

Milestone

v6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ThyMinimalDev @emrysal @keithwillcode