Skip to content

Conversation

@sean-brydon
Copy link
Member

@sean-brydon sean-brydon commented Nov 21, 2025

Fixes the filter on team invites


Summary by cubic

Fixes invite role resolution to correctly use the user’s membership in the parent organization, ensuring invites apply the intended role and create the right memberships.

  • Bug Fixes
    • Updated createMemberships to find the user’s org role by matching teamId to parentId (instead of using the first team membership).
    • Added tests for role selection across cases: unrelated team roles, existing org admin, no org membership, and no parent org.
    • Ensures the inviter’s chosen role is applied when appropriate and preserves admin when the user is already admin in the parent org.

Written for commit d1092c3. Summary will update automatically on new commits.

@graphite-app graphite-app bot requested a review from a team November 21, 2025 15:44
@keithwillcode keithwillcode added consumer core area: core, team members only labels Nov 21, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and tested

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

E2E results are ready!

@vercel
Copy link

vercel bot commented Nov 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Nov 21, 2025 6:07pm
cal-eu Ignored Ignored Nov 21, 2025 6:07pm

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@Udit-takkar Udit-takkar merged commit 0d77fc8 into main Nov 21, 2025
39 checks passed
@Udit-takkar Udit-takkar deleted the fix/invite-users-refactor branch November 21, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only ready-for-e2e size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants