Skip to content

Conversation

@sudoKrishna
Copy link

@sudoKrishna sudoKrishna commented Nov 24, 2025

What does this PR do?

This PR fixes an issue where the Weekly Calendar View becomes unclickable when using non-standard meeting durations such as 25 minutes. The issue occurred because the grid layout relied on 60 / eventDuration, which produces fractional values (example: 60 / 25 = 2.4), leading to:

Misaligned calendar cells

Unresponsive click regions

Overlay events failing to apply correctly

This update replaces fractional grid sizing with a consistent normalized 5-minute interval layout, making the calendar fully interactive and visually stable regardless of the selected duration.

Fixes

Fixes #25344

Fixes CAL-25344

Visual Demo
Before (Broken behavior):

Screen.Recording.2025-11-24.125544.mp4

After (Fixed behavior):

Video.Project.mp4

How should this be tested?

Open the weekly view calendar.

Set the event duration to 25 minutes (or any duration not divisible by 60).

Click any available time slot.

Expected behavior:

✔️ Time slot becomes selectable

✔️ Hover state and selection logic behave normally

✔️ Overlay-busy events still render correctly

✔️ UI behaves consistently with 15m, 30m, and 60m slots

No environment variables or configuration changes required.

Checklist

Code follows existing styling patterns

Added comments for non-trivial logic

No new console warnings introduced

@sudoKrishna sudoKrishna requested a review from a team as a code owner November 24, 2025 08:34
@vercel
Copy link

vercel bot commented Nov 24, 2025

@sudoKrishna is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2025

CLA assistant check
All committers have signed the CLA.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Nov 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title " Fix: Weekly view was not clickable when meeting duration is 25 minutes   #25344". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added the 🐛 bug Something isn't working label Nov 24, 2025
@sudoKrishna sudoKrishna changed the title Fix: Weekly view was not clickable when meeting duration is 25 minutes #25344 fix: weekly view was not clickable when meeting duration is 25 minutes (#25344) Nov 24, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@github-actions github-actions bot added the High priority Created by Linear-GitHub Sync label Nov 24, 2025
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudoKrishna Please remove un related changes in packages/prisma/.env and .gitignore

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still the same problem #25358 (review).

You need to make sure you don't push changes that are not needed for the fix. you don't have to delete .gitignore file but keep it same as before and same of prisma/.env

@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

25m meeting: Weekly view is not clickable, and no respect for conflicts.

4 participants