-
Notifications
You must be signed in to change notification settings - Fork 11.1k
fix: weekly view was not clickable when meeting duration is 25 minutes (#25344) #25358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@sudoKrishna is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
Udit-takkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sudoKrishna Please remove un related changes in packages/prisma/.env and .gitignore
Udit-takkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still the same problem #25358 (review).
You need to make sure you don't push changes that are not needed for the fix. you don't have to delete .gitignore file but keep it same as before and same of prisma/.env
What does this PR do?
This PR fixes an issue where the Weekly Calendar View becomes unclickable when using non-standard meeting durations such as 25 minutes. The issue occurred because the grid layout relied on 60 / eventDuration, which produces fractional values (example: 60 / 25 = 2.4), leading to:
Misaligned calendar cells
Unresponsive click regions
Overlay events failing to apply correctly
This update replaces fractional grid sizing with a consistent normalized 5-minute interval layout, making the calendar fully interactive and visually stable regardless of the selected duration.
Fixes
Fixes #25344
Fixes CAL-25344
Visual Demo
Before (Broken behavior):
Screen.Recording.2025-11-24.125544.mp4
After (Fixed behavior):
Video.Project.mp4
How should this be tested?
Open the weekly view calendar.
Set the event duration to 25 minutes (or any duration not divisible by 60).
Click any available time slot.
Expected behavior:
✔️ Time slot becomes selectable
✔️ Hover state and selection logic behave normally
✔️ Overlay-busy events still render correctly
✔️ UI behaves consistently with 15m, 30m, and 60m slots
No environment variables or configuration changes required.
Checklist
Code follows existing styling patterns
Added comments for non-trivial logic
No new console warnings introduced