fix: Onboarding v3 - create team then invite. #25364
Open
+166
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
sean-brydon
commented
Nov 24, 2025
| return redirect("/onboarding/teams/invite/email"); | ||
| const redirectUrl = teamId | ||
| ? `/onboarding/teams/invite/email?teamId=${teamId}` | ||
| : "/onboarding/teams/invite/email"; |
Member
Author
There was a problem hiding this comment.
We will try to pull from context if this part of the flow happens (it never should)
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
5 issues found across 7 files
Prompt for AI agents (all 5 issues)
Understand the root cause of the following 5 issues and fix them.
<file name="apps/web/modules/onboarding/hooks/useCreateTeam.ts">
<violation number="1" location="apps/web/modules/onboarding/hooks/useCreateTeam.ts:67">
User-facing error text should use t() instead of a hard-coded English string per the localization guideline.</violation>
<violation number="2" location="apps/web/modules/onboarding/hooks/useCreateTeam.ts:77">
Localize this validation error with t() instead of embedding English text directly.</violation>
<violation number="3" location="apps/web/modules/onboarding/hooks/useCreateTeam.ts:118">
Use the t() localization helper for this fallback invite error instead of a hard-coded string.</violation>
</file>
<file name="apps/web/modules/onboarding/teams/details/team-details-view.tsx">
<violation number="1" location="apps/web/modules/onboarding/teams/details/team-details-view.tsx:84">
createTeam is invoked with a stale onboarding-store snapshot, so the newly entered team name/slug never reach the mutation and the flow bounces the user back to the details step.</violation>
</file>
<file name="apps/web/modules/onboarding/teams/invite/email/team-invite-email-view.tsx">
<violation number="1" location="apps/web/modules/onboarding/teams/invite/email/team-invite-email-view.tsx:81">
Remove the hardcoded English fallback so this toast message always comes from `t()` and remains localizable.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
apps/web/modules/onboarding/teams/invite/email/team-invite-email-view.tsx
Show resolved
Hide resolved
Contributor
E2E results are ready! |
eunjae-lee
approved these changes
Nov 24, 2025
Contributor
eunjae-lee
left a comment
eunjae-lee
left a comment
There was a problem hiding this comment.
looks good. it worked well on my machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the order of creating the team -> paying -> invite users.
The old approach was create team -> invite -> pay. But we are matching the current implementation of how billing works with usage based billing
How should this be tested?
Enable onboarding-v3 flag on your instance
Ensure you have stripe enabled + stripe:listen running
login as [email protected], onboarding
Go through the team setup flow
Pay
Invite
Ensure uers were added to team
Create a new account
disable billing
Test again
Checklist