fix: google meet link is disappear when a seat is cancelled #25368
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikdhabal
commented
Nov 24, 2025
| calendarDescription: getRichDescription(evt), | ||
| }; | ||
| if (reference.type.includes("_video")) { | ||
| if (reference.type.includes("_video") && reference.type !== "google_meet_video") { |
Contributor
Author
There was a problem hiding this comment.
Skip updating video meetings for Google Meet - they're managed through Google Calendar. Currently throwing error as gmeet has no explicit videoadapter
anikdhabal
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/features/bookings/lib/handleSeats/cancel/cancelAttendeeSeat.ts">
<violation number="1" location="packages/features/bookings/lib/handleSeats/cancel/cancelAttendeeSeat.ts:97">
Video call data assignment logic duplicates `packages/features/bookings/lib/handleNewBooking/addVideoCallDataToEvent.ts:addVideoCallDataToEvent()` function. This should be refactored to use the existing utility to ensure consistency and maintainability.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Udit-takkar
reviewed
Nov 25, 2025
Contributor
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
@anikdhabal can we add some automated tests?
volnei
approved these changes
Nov 25, 2025
Contributor
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summary by cubic
Fixes loss of Google Meet link when cancelling a single attendee seat. Seat cancellations no longer modify the Google Meet conference, and video call details are preserved for other providers.
Written for commit 979c268. Summary will update automatically on new commits.