-
Notifications
You must be signed in to change notification settings - Fork 11.1k
fix: prevent 500 errors in round-robin scheduling from OOO calibration for single host #25369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
05c9bcc to
f2b2b6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
E2E results are ready! |
What does this PR do?
Fixes 500 error (
"Internal Error: Weight filter should never return length=0.") in round-robin scheduling caused bybookingsInTimeframe.length / (hosts.length - 1)causes division by zeroThis issues causes NaN to propagate through booking shortfall calculations, resulting in
Math.max(...NaN values) = NaN, and the filteruser.bookingShortfall === NaNreturns an empty array (sinceNaN !== NaN), triggering the error"Internal Error: Weight filter should never return length=0."Solutions implemented:
hosts.length <= 1(conceptually meaningless with a single host)Mandatory Tasks