Skip to content

Conversation

@hackice20
Copy link
Contributor

What does this PR do?

Documents the isEmbed prop in CalProvider, clarifies when to use it, and hardens the API so x-cal-platform-embed: true only bypasses OAuth client metadata when the request truly comes from Cal’s managed embed OAuth client.

Visual Demo (For contributors especially)

Image Demo (if applicable):

PR vaste Screenshot From 2025-11-24 21-45-37

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Docs
    Run mintlify dev under docs/.
    Open /platform/atoms/cal-provider and verify isEmbed appears in the props table with the warning.
  • API
    wrote a test file to check this , my laptop can't handle the load to run the backend.

Checklist

  • I have read the contributing guide
  • My code does follow the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked if my changes generate no new warnings

@hackice20 hackice20 requested a review from a team as a code owner November 24, 2025 16:28
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Nov 24, 2025
@vercel
Copy link

vercel bot commented Nov 24, 2025

@hackice20 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

@hackice20
Copy link
Contributor Author

Hello @anikdhabal can you please review this PR ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync reactive⚡︎ size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: CalProvider isEmbed

2 participants