Support oauth2 compatible auth responses (uses access_token field, not token)#174
Open
edwardgeorge wants to merge 1 commit into
Open
Support oauth2 compatible auth responses (uses access_token field, not token)#174edwardgeorge wants to merge 1 commit into
access_token field, not token)#174edwardgeorge wants to merge 1 commit into
Conversation
Adds support for more container registries, eg: Azure.
According to the docker specs:
For compatibility with OAuth 2.0, we will also accept token under the name
access_token. At least one of these fields must be specified, but both may
also appear (for compatibility with older clients). When both are specified,
they should be equivalent; if they differ the client's choice is undefined.
Serde doesn't support deriving a Deserialize instance with required fields that
may appear under multiple names, so rather than manually implement the trait
here we use an intermediate struct with a TryFrom implementation.
Contributor
Author
|
@steveej this PR is perhaps a little more controversial with using the intermediate struct. I favoured this initially as it kept it as part of deserialisation and left the auth logic untouched and ensured that the An alternative approach is implemented in this branch here: master...edwardgeorge:access_token_getter If you prefer that method I can overwrite the commit in this PR with the commit from this other branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for more container registries, eg: Azure (which is what I am attempting to use, requiring this change).
According to the docker specs:
Serde doesn't support deriving a
Deserializeinstance with required fields that may appear under multiple names, so rather than manually implement the complexDeserializetrait here we use an intermediate struct with a simplerTryFromimplementation. No changes to the auth handling logic itself.