Fix stm32g0b USB stall #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lichtfeind has opened an issue STMicroelectronics/stm32g0xx-hal-driver#2 to fix this problem upstream. |
fenugrec
reviewed
Jan 18, 2023
fenugrec
reviewed
Jan 18, 2023
fenugrec
reviewed
Jan 18, 2023
2 tasks
marckleinebudde
force-pushed
the
fix-stm32g0b-usb-stall
branch
from
95b7108 to
808737f
Compare
Cherry-picked from upstream commit Fixes: e289146768cf ("[LL][USB] Use
correct macro to clear RXBD register block numbers")
https://github.com/STMicroelectronics/stm32g0xx_hal_driver.git
Having two writes to clean and set COUNTn_RX and NUM_BLOCK results in a small windows in which COUNTn_RX and NUM_BLOCK are zero. This results in a stall as the buffer is empty (ready to receive) but also has no space to receive the package into. Signed-off-by: Jonas Martin <[email protected]>
marckleinebudde
force-pushed
the
fix-stm32g0b-usb-stall
branch
from
808737f to
dffacde
Compare
|
Thanks. Sorry for the delay; I was hoping ST would update the library 'soon' as that would have been preferable to having local fixes (see #157 for my dilemma...) |
|
At least it's on their dashboard now: https://github.com/orgs/STMicroelectronics/projects/3#card-87981733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under high CAN-TX load the endpoint on the stm32g0b will stall, this PR fixes the issue.