-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Node.js 20 rock for Noble #8
base: main
Are you sure you want to change the base?
Conversation
canonical/chisel-releases#182 is merged. |
Could you please update the GitHub workflow so that it runs the tests on the node20 image too? |
666e4dc
to
71741df
Compare
71741df
to
f203c8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Interesting work.
TBH, I wouldn't merge this because it can easily backfire on us. For several reasons:
- node20 isn't in the archives, so what is our support commitment for such an image?
- I'm not too sure about the rockfile. I.e., slices are being installed, but then the whole node snap is also being installed, which by itself should already bring the node dependencies (which btw, are not chiselled). So is it really chiselled?
|
True. And don't get me wrong. This is useful. I would keep this as a feature branch. |
I will keep this branch then as a feature and change the rock so it uses something other the node snap. |
But not as a rock. Aren't we going to rockify it like we did with Python before? |
when it's time to publish it, yes. But that's not a priority for now. |
Any news on supporting v20? Has any circumstances changed ? |
Node.js 20 is available in Ubuntu 24.10 archives (https://packages.ubuntu.com/oracular/nodejs), so once we finish migrating chisel slice definition files from 24.04 to 24.10, creating a rock for Node.js 20 will be very straightforward. |
This add the rockcraft.yaml for Node.js built on 24.04.
Since there is no apt package for Node.js 20 on 24.04 yet (currently there is only Node.js 18 there), I opted to install Nodejs binaries using snap instead.
Note that the Nodejs snap include the package managers npm and yarn. yarn in particular needs bash, coreutils and sed to work because it is basically a shell script.
This is waiting on canonical/chisel-releases#182 to be merged.