Sandbox experiment #1065
Draft
Sandbox experiment #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Mars <[email protected]>
upils
force-pushed
the
work/experiment-chroot
branch
from
94f92fc to
b8f6657
Compare
Signed-off-by: Paul Mars <[email protected]>
cmatsuoka
reviewed
Apr 15, 2025
Comment on lines
+46
to
+47
| def __init__(self, target: Path, content: str) -> None: | ||
| self._target = target |
Collaborator
There was a problem hiding this comment.
Maybe a name like ContentReplacer or (FileContentReplacer) and then use replace() and restore()? Or even a context manager for that so it could look like:
with FileContentReplacer("/etc/issue"):
do_my_stuff()
If the context manager can't be used it could be something like:
d = FileContentReplacer("/etc/issue")
d.replace()
do_my_stuff()
d.restore()
But the context manager would make more sense in this use case imho.
Comment on lines
+372
to
+379
| try: | ||
| self._setup() | ||
| child.start() | ||
| res, err = parent_conn.recv() | ||
| child.join() | ||
| finally: | ||
| logger.debug("[pid=%d] clean up the sandbox", os.getpid()) | ||
| self._cleanup() |
Collaborator
There was a problem hiding this comment.
It seems that this try-finally could be a context manager.
Signed-off-by: Paul Mars <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/reference/changelog.rst)?Expand the chroot into a sandbox.
Usage example https://github.com/canonical/imagecraft/tree/work/experiment-chroot