feature(pro_sources): craftctl chroot cmd #1350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clay-lake
requested review from
cmatsuoka,
jahn-junior and
medubelko
as code owners
Author
|
@tigarmo @canonical/starcraft-reviewers Need a review when you can 👀 |
lengau
reviewed
Oct 3, 2025
| raise invalid_control_api_call( | ||
| message=( | ||
| f"invalid arguments to command {cmd_name!r} (want key=value)" | ||
| f"invalid arguments. {cmd_name!r} expected format <key>=<value>" |
Contributor
There was a problem hiding this comment.
Please update test_craftctl_set_argument_error for this
lengau
reviewed
Oct 3, 2025
| message=f"{cmd_name!r} can only run in overlay step", | ||
| ) | ||
|
|
||
| if len(cmd_args) < 1: |
Contributor
There was a problem hiding this comment.
Suggested change
| if len(cmd_args) < 1: | |
| if not cmd_args: |
lengau
reviewed
Oct 3, 2025
| assert lf.project_info.get_project_var("myvar2") == "val2" | ||
|
|
||
|
|
||
| def test_craftctl_chroot(new_dir, partitions, mocker): |
Contributor
There was a problem hiding this comment.
Patching out chroot etc. makes this look like a unit test to me. Could you make an integration test that runs a real command inside the chroot?
medubelko
approved these changes
Oct 7, 2025
Contributor
medubelko
left a comment
medubelko
left a comment
There was a problem hiding this comment.
I suggested some polish for the release note. :)
Comment on lines
+28
to
+29
| - Introduced a new sub command called ``chroot`` to ``craftctl`` which allows users to | ||
| run a command inside the overlay of a part. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Introduced a new sub command called ``chroot`` to ``craftctl`` which allows users to | |
| run a command inside the overlay of a part. | |
| - Add ``craftctl chroot`` sub-command, for running a command inside a part's overlay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of Rockcraft's
pro_sourcesfeature set and includes the following features:chrootsub command forcraftctlto enable modification to the overlay during theoverlay-script