fix: brief only when __str__ for errors #929
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plays better with Craft CLIs current design. Signed-off-by: Sergio Schvezov <[email protected]>
tigarmo
reviewed
Dec 9, 2024
| components.append(self.resolution) | ||
|
|
||
| return "\n".join(components) | ||
| return self.brief |
Contributor
There was a problem hiding this comment.
I still don't understand how this error is ending up in craft-cli?
Contributor
|
I'm pretty sure this PR is obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plays better with Craft CLIs current design as seen in
https://github.com/canonical/craft-cli/blob/main/craft_cli/messages.py#L733