feat: add support for disabling alert rules forwarding #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making it a draft because this PR is useful for code review, but it shouldn't be merged before the Prometheus one. |
sed-i
reviewed
Feb 5, 2025
sed-i
reviewed
Feb 7, 2025
sed-i
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Partially addresses #154
Solution
Add a
juju configoption nameddisable_forwarding_alert_rules(the name is up for discussion) to (you guessed it) disable the forwarding of alert rules, including grafana-agent's own alerts.This PR achieves that by adding the aforementioned config option, which defaults to
false, and passingNoneasalert_rules_pathto thePrometheusRemoteWriteConsumer.In tandem with canonical/prometheus-k8s-operator#673 this should address the isssue for grafana-agent.
Testing Instructions
Pack and deploy both this charm and Prometheus, connect them, and test this new flag.
Screenshots