Fix dashboards still existing after relation removal #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
reviewed
Feb 5, 2025
|
Here's a QA you could add to the "Testing" section of the PR description. Before this change, the dashboards from hardware-observer are still present in grafana after default-base: [email protected]/stable
saas:
grafana:
url: microk8s:admin/welcome-k8s.grafana
applications:
grafana-agent:
charm: ./[email protected]
hardware-observer:
charm: hardware-observer
channel: latest/edge
revision: 160
resources:
perccli-deb: 1
sas2ircu-bin: 1
sas3ircu-bin: 1
storcli-deb: 1
ubuntu:
charm: ubuntu
channel: latest/stable
revision: 25
num_units: 2
relations:
- - ubuntu:juju-info
- hardware-observer:general-info
- - ubuntu:juju-info
- grafana-agent:juju-info
- - grafana-agent:grafana-dashboards-provider
- grafana:grafana-dashboard
- - grafana-agent:cos-agent
- hardware-observer:cos-agent |
sed-i
approved these changes
Feb 6, 2025
Co-authored-by: Leon <[email protected]> Signed-off-by: Michael Dmitry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes canonical/grafana-k8s-operator#346
Solution
On remote relation departed, empty peer data of grafana-agent for that departing relation
Context
canonical/grafana-k8s-operator#386
Drive-bys
Testing Considerations
Deploy this bundle
Then,
Then, verify that the hardware observer dashboard has been remove from grafana.