Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setup lxd with group "lxd" in GH actions #1096

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: setup lxd with group "lxd" in GH actions #1096

merged 1 commit into from
Feb 10, 2025

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Feb 7, 2025

Done

  • Fix issue with lxd group membership in github actions. It was failing the install LXD step previously for the latest/edge version of the lxd snap (something must have changed there).

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Ensure CI passes

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@mas-who mas-who force-pushed the fix-lxd-group-action-issue branch 17 times, most recently from 4e7c198 to 90ec31b Compare February 10, 2025 08:56
@mas-who mas-who force-pushed the fix-lxd-group-action-issue branch from 90ec31b to d869ca0 Compare February 10, 2025 09:01
edlerd
edlerd approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@mas-who mas-who merged commit 4626024 into canonical:main Feb 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mas-who @webteam-app @edlerd