use charm-tracing-config #585
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
force-pushed
the
chore/charm-tracing-config-and-tls
branch
from
c100ea5 to
8027dff
Compare
PietroPasotti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
mysql-k8s doesn't use
charm_tracing_configwhich is the recommended way to use charm tracing together with tracing v1TODO:
Side-note: I also noticed that mysql-k8s at the moment doesn't configure a tls cert for charm_tracing to use, so the charm would break if tempo were to be related to a certificates provider.
Opened #586 to track, and added a big fixme in-code.