Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations update from Hosted Weblate #1094

Conversation

weblate
Copy link
Contributor

@weblate weblate commented Jan 31, 2025

Translations update from Hosted Weblate for ubuntu-desktop-translations/Ubuntu Pro for WSL.

Current translation status:

Weblate translation status


UDENG-266

ashuntu and others added 8 commits January 30, 2025 21:42
Currently translated at 4.7% (3 of 63 strings)

Translation: ubuntu-desktop-translations/Ubuntu Pro for WSL
Translate-URL: https://hosted.weblate.org/projects/ubuntu-desktop-translations/ubuntu-pro-for-wsl/pt_BR/
Currently translated at 11.1% (7 of 63 strings)

Translation: ubuntu-desktop-translations/Ubuntu Pro for WSL
Translate-URL: https://hosted.weblate.org/projects/ubuntu-desktop-translations/ubuntu-pro-for-wsl/pt_BR/
Currently translated at 11.1% (7 of 63 strings)

Translation: ubuntu-desktop-translations/Ubuntu Pro for WSL
Translate-URL: https://hosted.weblate.org/projects/ubuntu-desktop-translations/ubuntu-pro-for-wsl/pt_BR/
Currently translated at 0.0% (0 of 63 strings)

Translation: ubuntu-desktop-translations/Ubuntu Pro for WSL
Translate-URL: https://hosted.weblate.org/projects/ubuntu-desktop-translations/ubuntu-pro-for-wsl/fr/
@weblate weblate requested a review from a team as a code owner January 31, 2025 00:50
@ashuntu
Copy link
Collaborator

ashuntu commented Jan 31, 2025

Looks like it finally works!

@CarlosNihelton do you know what happens when empty strings are present for some translations? I assume Flutter is smart enough to fall back to English? I'll test myself tomorrow

Also just a note for myself: we need to test strings that are unexpectedly long due to translations and handle it accordingly.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.19%. Comparing base (16be50c) to head (dfc299b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
- Coverage   89.22%   88.19%   -1.03%     
==========================================
  Files         113       88      -25     
  Lines        7556     6576     -980     
==========================================
- Hits         6742     5800     -942     
+ Misses        638      597      -41     
- Partials      176      179       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlosNihelton
Copy link
Contributor

@CarlosNihelton do you know what happens when empty strings are present for some translations?

The translation system correctly falls back when strings are missing. Empty strings are not missing strings, thus it blindly renders empty strings in the result. I'm a bit surprised to see those empty strings in the Weblate PR. Non-translated strings should not be present in the ARB file. Perharps that's an unexpected result of yesterday's instability in the website?

Additionally, I just realized that we need to skip the end-to-end CI workflow in weblate's pull requests. As it only touches strings, there is little value in attempting to run it, and also it depends on repository secrets not available for forks.

Currently translated at 50.7% (32 of 63 strings)

Translation: ubuntu-desktop-translations/Ubuntu Pro for WSL
Translate-URL: https://hosted.weblate.org/projects/ubuntu-desktop-translations/ubuntu-pro-for-wsl/pt_BR/
@ashuntu
Copy link
Collaborator

ashuntu commented Jan 31, 2025

Additionally, I just realized that we need to skip the end-to-end CI workflow in weblate's pull requests. As it only touches strings, there is little value in attempting to run it, and also it depends on repository secrets not available for forks.

Yeah it only ran because I manually approved and ran them, just to see.

Non-translated strings should not be present in the ARB file. Perharps that's an unexpected result of yesterday's instability in the website?

Maybe. I thought I remembered an option to change this behavior, but looking at it now I can't find such an option. I'll see what I can come up with.

ashuntu added a commit that referenced this pull request Jan 31, 2025
This is so we don't have to manually add the languages in Weblate
itself.

Purposely excludes French and Brazilian Portuguese since those are added
by #1094.

---

UDENG-266
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this.

@ashuntu ashuntu merged commit 336f04f into canonical:main Jan 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants