-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations update from Hosted Weblate #1094
Translations update from Hosted Weblate #1094
Conversation
Currently translated at 4.7% (3 of 63 strings) Translation: ubuntu-desktop-translations/Ubuntu Pro for WSL Translate-URL: https://hosted.weblate.org/projects/ubuntu-desktop-translations/ubuntu-pro-for-wsl/pt_BR/
Currently translated at 11.1% (7 of 63 strings) Translation: ubuntu-desktop-translations/Ubuntu Pro for WSL Translate-URL: https://hosted.weblate.org/projects/ubuntu-desktop-translations/ubuntu-pro-for-wsl/pt_BR/
Currently translated at 11.1% (7 of 63 strings) Translation: ubuntu-desktop-translations/Ubuntu Pro for WSL Translate-URL: https://hosted.weblate.org/projects/ubuntu-desktop-translations/ubuntu-pro-for-wsl/pt_BR/
Currently translated at 0.0% (0 of 63 strings) Translation: ubuntu-desktop-translations/Ubuntu Pro for WSL Translate-URL: https://hosted.weblate.org/projects/ubuntu-desktop-translations/ubuntu-pro-for-wsl/fr/
Looks like it finally works! @CarlosNihelton do you know what happens when empty strings are present for some translations? I assume Flutter is smart enough to fall back to English? I'll test myself tomorrow Also just a note for myself: we need to test strings that are unexpectedly long due to translations and handle it accordingly. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1094 +/- ##
==========================================
- Coverage 89.22% 88.19% -1.03%
==========================================
Files 113 88 -25
Lines 7556 6576 -980
==========================================
- Hits 6742 5800 -942
+ Misses 638 597 -41
- Partials 176 179 +3 ☔ View full report in Codecov by Sentry. |
The translation system correctly falls back when strings are missing. Empty strings are not missing strings, thus it blindly renders empty strings in the result. I'm a bit surprised to see those empty strings in the Weblate PR. Non-translated strings should not be present in the ARB file. Perharps that's an unexpected result of yesterday's instability in the website? Additionally, I just realized that we need to skip the end-to-end CI workflow in weblate's pull requests. As it only touches strings, there is little value in attempting to run it, and also it depends on repository secrets not available for forks. |
Currently translated at 50.7% (32 of 63 strings) Translation: ubuntu-desktop-translations/Ubuntu Pro for WSL Translate-URL: https://hosted.weblate.org/projects/ubuntu-desktop-translations/ubuntu-pro-for-wsl/pt_BR/
Yeah it only ran because I manually approved and ran them, just to see.
Maybe. I thought I remembered an option to change this behavior, but looking at it now I can't find such an option. I'll see what I can come up with. |
This is so we don't have to manually add the languages in Weblate itself. Purposely excludes French and Brazilian Portuguese since those are added by #1094. --- UDENG-266
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for taking care of this.
Translations update from Hosted Weblate for ubuntu-desktop-translations/Ubuntu Pro for WSL.
Current translation status:
UDENG-266