Skip to content

Commit

Permalink
Remove use of globals package with mirrored values from sap/cds (#499)
Browse files Browse the repository at this point in the history
  • Loading branch information
daogrady authored Feb 24, 2025
1 parent 43f6ab1 commit c584580
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 21 deletions.
15 changes: 9 additions & 6 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
module.exports = [
//
// aiife to allow dynamic import of cds/eslint.config.mjs
module.exports = (async () => [
{
ignores: ['**/test/integration/**'],
ignores: [
'**/test/integration/**',
'**/test/**/_out', // no auto-transpiled test files
'**/@cds-models' // no generated model files
],
},
require('@eslint/js').configs.recommended,
require('eslint-plugin-jsdoc').configs['flat/recommended-typescript-flavor-error'],
Expand All @@ -10,8 +14,7 @@ module.exports = [
ecmaVersion: 'latest',
sourceType: 'commonjs',
globals: {
...require('globals').node,
jest: true
...(await import('@sap/cds/eslint.config.mjs')).defaults.languageOptions.globals
}
},
files: ['**/*.js'],
Expand Down Expand Up @@ -92,4 +95,4 @@ module.exports = [
'jsdoc/require-returns': 'off', // lsp can infer this most of the time, turn back on for doc extraction
}
}
]
])()
14 changes: 0 additions & 14 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
"acorn": "^8.10.0",
"eslint": "^9",
"eslint-plugin-jsdoc": "^50.2.2",
"globals": "^15.0.0",
"typescript": ">=4.6.4"
},
"cds": {
Expand Down

0 comments on commit c584580

Please sign in to comment.