Skip to content

Fix no_std error trait implementation #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

elagil
Copy link

@elagil elagil commented Apr 1, 2025

As far as I can tell, the Error trait is not fully implemented for no_std. This should fix it.

@dwrensha
Copy link
Member

dwrensha commented Apr 1, 2025

Ah, I suppose that rust-lang/rust#99917 made this possible.

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.41%. Comparing base (ab342b3) to head (f74697c).
Report is 140 commits behind head on master.

Files with missing lines Patch % Lines
capnp/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   51.64%   52.41%   +0.77%     
==========================================
  Files          69       70       +1     
  Lines       33735    34615     +880     
==========================================
+ Hits        17422    18144     +722     
- Misses      16313    16471     +158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elagil
Copy link
Author

elagil commented Apr 1, 2025

I guess bumping the rust version for the package would be required. Is that acceptable?

@dwrensha dwrensha added the breaking change requires version bump label Apr 1, 2025
@dwrensha
Copy link
Member

dwrensha commented Apr 1, 2025

I added the "Breaking Change" label to this PR. We should include this when we bump the version to v0.21.0.

@dwrensha
Copy link
Member

dwrensha commented Apr 7, 2025

rebased onto master in 7f5c15d

@dwrensha dwrensha closed this Apr 7, 2025
@elagil elagil deleted the fix_core_error_trait branch April 8, 2025 07:04
@elagil
Copy link
Author

elagil commented Apr 8, 2025

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change requires version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants