Skip to content

fish: reduce xargs calls #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsteube merged 1 commit into from
Oct 20, 2025
Merged

fish: reduce xargs calls #1169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions example/cmd/_test/fish.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,14 @@
function _example_quote_suffix
if not commandline -cp | xargs echo 2>/dev/null >/dev/null
if echo (commandline -cp)'"' | xargs echo 2>/dev/null >/dev/null
echo '"'
else if echo (commandline -cp)"'" | xargs echo 2>/dev/null >/dev/null
echo "'"
function _example_completion
IFS='' set data (echo (commandline -cp)'' | sed "s/ \$/ ''/" | xargs example _carapace fish 2>/dev/null)
if [ $status -eq 1 ]
IFS='' set data (echo (commandline -cp)"'" | sed "s/ \$/ ''/" | xargs example _carapace fish 2>/dev/null)
if [ $status -eq 1 ]
IFS='' set data (echo (commandline -cp)'"' | sed "s/ \$/ ''/" | xargs example _carapace fish 2>/dev/null)
end
else
echo ""
end
end

function _example_callback
echo (commandline -cp)(_example_quote_suffix) | sed "s/ \$/ ''/" | xargs example _carapace fish
echo $data
end

complete -e 'example'
complete -c 'example' -f -a '(_example_callback)' -r
complete -c 'example' -f -a '(_example_completion)' -r

25 changes: 10 additions & 15 deletions internal/shell/fish/snippet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,18 @@ import (

// Snippet creates the fish completion script.
func Snippet(cmd *cobra.Command) string {
return fmt.Sprintf(`function _%v_quote_suffix
if not commandline -cp | xargs echo 2>/dev/null >/dev/null
if echo (commandline -cp)'"' | xargs echo 2>/dev/null >/dev/null
echo '"'
else if echo (commandline -cp)"'" | xargs echo 2>/dev/null >/dev/null
echo "'"
return fmt.Sprintf(`function _%[1]v_completion
IFS='' set data (echo (commandline -cp)'' | sed "s/ \$/ ''/" | xargs %[2]v _carapace fish 2>/dev/null)
if [ $status -eq 1 ]
IFS='' set data (echo (commandline -cp)"'" | sed "s/ \$/ ''/" | xargs %[2]v _carapace fish 2>/dev/null)
if [ $status -eq 1 ]
IFS='' set data (echo (commandline -cp)'"' | sed "s/ \$/ ''/" | xargs %[2]v _carapace fish 2>/dev/null)
end
else
echo ""
end
echo $data
end

function _%v_callback
echo (commandline -cp)(_%v_quote_suffix) | sed "s/ \$/ ''/" | xargs %v _carapace fish
end

complete -e '%v'
complete -c '%v' -f -a '(_%v_callback)' -r
`, cmd.Name(), cmd.Name(), cmd.Name(), uid.Executable(), cmd.Name(), cmd.Name(), cmd.Name())
complete -e '%[1]v'
complete -c '%[1]v' -f -a '(_%[1]v_completion)' -r
`, cmd.Name(), uid.Executable())
}