fix: fix issue with incorrect transaction size and ttl

.env.IntegrationTest

@@ -101,4 +101,3 @@ YACI_HTTP_BASE_URL=http://localhost:9095/api/v1
 YACI_INDEXER_PORT=9095
 HTTP_CONNECT_TIMEOUT_SECONDS=5
 HTTP_REQUEST_TIMEOUT_SECONDS=5
-

.env.docker-compose

@@ -60,7 +60,6 @@ INDEXER_DOCKER_IMAGE_TAG=main
 PRUNING_ENABLED=false
 
 YACI_SPRING_PROFILES=postgres,n2c-socket
-YACI_INDEXER_PORT=9095
 # database profiles: h2, h2-testData, postgres
 MEMPOOL_ENABLED=false
 

api/pom.xml

@@ -89,6 +89,11 @@
             <artifactId>jackson-dataformat-yaml</artifactId>
         </dependency>
 
+        <dependency>
+            <groupId>org.cardanofoundation</groupId>
+            <artifactId>cf-cardano-conversions-java</artifactId>
+        </dependency>
+
         <dependency>
             <groupId>org.openapitools</groupId>
             <artifactId>jackson-databind-nullable</artifactId>

api/src/main/java/org/cardanofoundation/rosetta/RosettaApiApplication.java

@@ -66,6 +66,8 @@ public CommonsRequestLoggingFilter logFilter() {
     filter.setMaxPayloadLength(10000);
     filter.setIncludeHeaders(false);
     filter.setAfterMessagePrefix("REQUEST DATA: \n");
+
     return filter;
   }
+
 }

api/src/main/java/org/cardanofoundation/rosetta/api/account/controller/AccountApiImplementation.java

@@ -32,7 +32,7 @@ public class AccountApiImplementation implements AccountApi {
   public ResponseEntity<AccountBalanceResponse> accountBalance(
       @Valid @RequestBody AccountBalanceRequest accountBalanceRequest) {
     if(offlineMode) {
-      throw ExceptionFactory.NotSupportedInOfflineMode();
+      throw ExceptionFactory.notSupportedInOfflineMode();
     }
     networkService.verifyNetworkRequest(accountBalanceRequest.getNetworkIdentifier());
 
@@ -43,7 +43,7 @@ public ResponseEntity<AccountBalanceResponse> accountBalance(
   public ResponseEntity<AccountCoinsResponse> accountCoins(
       @Valid @RequestBody AccountCoinsRequest accountCoinsRequest) {
     if(offlineMode) {
-      throw ExceptionFactory.NotSupportedInOfflineMode();
+      throw ExceptionFactory.notSupportedInOfflineMode();
     }
     networkService.verifyNetworkRequest(accountCoinsRequest.getNetworkIdentifier());
 

api/src/main/java/org/cardanofoundation/rosetta/api/block/controller/BlockApiImpl.java

@@ -35,7 +35,7 @@ public class BlockApiImpl implements BlockApi {
   @Override
   public ResponseEntity<BlockResponse> block(@RequestBody BlockRequest blockRequest) {
     if(offlineMode) {
-      throw ExceptionFactory.NotSupportedInOfflineMode();
+      throw ExceptionFactory.notSupportedInOfflineMode();
     }
     networkService.verifyNetworkRequest(blockRequest.getNetworkIdentifier());
 
@@ -52,7 +52,7 @@ public ResponseEntity<BlockResponse> block(@RequestBody BlockRequest blockReques
   public ResponseEntity<BlockTransactionResponse> blockTransaction(
       @RequestBody BlockTransactionRequest blockReq) {
     if(offlineMode) {
-      throw ExceptionFactory.NotSupportedInOfflineMode();
+      throw ExceptionFactory.notSupportedInOfflineMode();
     }
     networkService.verifyNetworkRequest(blockReq.getNetworkIdentifier());
 

api/src/main/java/org/cardanofoundation/rosetta/api/construction/controller/ConstructionApiImplementation.java

@@ -10,6 +10,8 @@
 import org.springframework.validation.annotation.Validated;
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RestController;
+import com.bloxbean.cardano.client.exception.CborDeserializationException;
+import com.bloxbean.cardano.client.exception.CborSerializationException;
 import org.openapitools.client.api.ConstructionApi;
 import org.openapitools.client.model.*;
 
@@ -48,8 +50,8 @@ public ResponseEntity<TransactionIdentifierResponse> constructionHash(@RequestBo
 
     @Override
     public ResponseEntity<ConstructionMetadataResponse> constructionMetadata(@RequestBody ConstructionMetadataRequest constructionMetadataRequest)  {
-        if(offlineMode) {
-            throw ExceptionFactory.NotSupportedInOfflineMode();
+        if (offlineMode) {
+            throw ExceptionFactory.notSupportedInOfflineMode();
         }
         networkService.verifyNetworkRequest(constructionMetadataRequest.getNetworkIdentifier());
         return ResponseEntity.ok(constructionApiService.constructionMetadataService(constructionMetadataRequest));
@@ -66,7 +68,13 @@ public ResponseEntity<ConstructionPayloadsResponse> constructionPayloads(@Reques
         networkService.verifyNetworkRequest(constructionPayloadsRequest.getNetworkIdentifier());
         constructionApiService.verifyProtocolParameters(constructionPayloadsRequest);
 
-        return ResponseEntity.ok(constructionApiService.constructionPayloadsService(constructionPayloadsRequest));
+        try {
+            return ResponseEntity.ok(constructionApiService.constructionPayloadsService(constructionPayloadsRequest));
+        } catch (CborDeserializationException | CborSerializationException e) {
+            log.error("Error in constructionPayloads", e);
+
+            throw ExceptionFactory.unspecifiedError("Error in constructionPayloads");
+        }
     }
 
     @Override
@@ -78,7 +86,7 @@ public ResponseEntity<ConstructionPreprocessResponse> constructionPreprocess(@Re
     @Override
     public ResponseEntity<TransactionIdentifierResponse> constructionSubmit(@RequestBody ConstructionSubmitRequest constructionSubmitRequest) {
         if(offlineMode) {
-            throw ExceptionFactory.NotSupportedInOfflineMode();
+            throw ExceptionFactory.notSupportedInOfflineMode();
         }
         networkService.verifyNetworkRequest(constructionSubmitRequest.getNetworkIdentifier());
         return ResponseEntity.ok(constructionApiService.constructionSubmitService(constructionSubmitRequest));

api/src/main/java/org/cardanofoundation/rosetta/api/construction/service/CardanoConstructionService.java

@@ -2,9 +2,7 @@
 
 
 import java.io.IOException;
-import java.math.BigInteger;
 import java.util.List;
-import java.util.Map;
 import java.util.Set;
 
 import co.nstant.in.cbor.CborException;
@@ -36,13 +34,12 @@ public interface CardanoConstructionService {
   TransactionParsed parseTransaction(Network network, String transaction, boolean signed);
 
   Integer checkOrReturnDefaultTtl(Integer relativeTtl);
-  Long updateTxSize(Long previousTxSize, Long previousTtl, Long updatedTtl);
   Long calculateTxMinimumFee(Long transactionSize, ProtocolParams protocolParameters);
 
   Signatures signatureProcessor(EraAddressType eraAddressType, AddressType addressType,
       String address);
 
-  Integer calculateTxSize(Network network, List<Operation> operations, int ttl, DepositParameters depositParameters);
+  Integer calculateTxSize(Network network, List<Operation> operations, long ttl);
 
   String buildTransaction(String unsignedTransaction,
       List<Signatures> signaturesList, String transactionMetadata);
@@ -53,13 +50,12 @@ TransactionWitnessSet getWitnessesForTransaction(
   List<SigningPayload> constructPayloadsForTransactionBody(String transactionBodyHash,
       Set<String> addresses);
 
-  Long calculateFee(List<BigInteger> inputAmounts, List<BigInteger> outputAmounts,
-      List<BigInteger> withdrawalAmounts, Map<String, Double> depositsSumMap);
-
   ProcessOperations convertRosettaOperations(Network network,
       List<Operation> operations) throws IOException;
 
-  UnsignedTransaction createUnsignedTransaction(Network network, List<Operation> operations, int ttl, DepositParameters depositParameters) throws IOException, CborSerializationException, AddressExcepion, CborException;
+  UnsignedTransaction createUnsignedTransaction(Network network, List<Operation> operations, long ttl, Long calculatedFee) throws IOException, CborSerializationException, AddressExcepion, CborException;
+
+  UnsignedTransaction createUnsignedTransaction(Network network, List<Operation> operations, long ttl) throws IOException, CborSerializationException, AddressExcepion, CborException;
 
   String submitTransaction(String signedTransaction);
   DepositParameters getDepositParameters();
@@ -68,4 +64,5 @@ ProcessOperations convertRosettaOperations(Network network,
 
   String getCardanoAddress(AddressType addressType, PublicKey stakingCredential,
       PublicKey publicKey, NetworkEnum networkEnum);
+
 }