Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): android wrong navigation when create group identifier #1013

Draft
wants to merge 2 commits into
base: release/1.0.0
Choose a base branch
from

Conversation

iFergal
Copy link
Collaborator

@iFergal iFergal commented Mar 7, 2025

Description

When scanning another group member's OOBI to finish setting up a group, we should be able to do this from the main scanner.

Also includes a fix to only allow meerkat IDs for the Cardano Connect scanner.

Pending: When scanning group OOBIs, either the initiator one, or other group members from the full page scanner (e.g. Connections page, as opened from any of the 3 locations), we should be able to continuing setting up the group correctly.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Before
After

Android

Before
After

Browser

Before
After

@iFergal iFergal self-assigned this Mar 7, 2025
@iFergal iFergal changed the base branch from main to release/1.0.0 March 7, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant