Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: out-order-ipex #962

Merged
merged 30 commits into from
Mar 3, 2025
Merged

feat: out-order-ipex #962

merged 30 commits into from
Mar 3, 2025

Conversation

jimcase
Copy link
Contributor

@jimcase jimcase commented Feb 17, 2025

Description

There are scenarios where we will receive notifications out of order. We add them to the failed queue so they get re-processed.

However, in the case of group IPEX, we may receive notifications that related to deleted notifications. For example, once the threshold is met when accepting a credential, the notification from the issuer is deleted.

There is a timing gap where the long running operation for accepting completes first, the notification is deleted, and then the notification is received to indicate that the other member has accepted.

We need to handle this better.

Error: OUT_OF_ORDER_NOTIFICATION

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

@jimcase jimcase self-assigned this Feb 19, 2025
@jimcase jimcase changed the title feat: save IPEX_AGREE_COMPLETE once agree long running operation is c… feat: out-order-ipex Feb 19, 2025
@jimcase jimcase marked this pull request as ready for review February 20, 2025 13:16
@jimcase jimcase requested a review from iFergal as a code owner February 20, 2025 13:16
iFergal
iFergal previously approved these changes Feb 26, 2025
@jimcase jimcase requested a review from obstar February 26, 2025 16:03
obstar
obstar previously approved these changes Mar 3, 2025
@iFergal iFergal dismissed stale reviews from obstar and themself via 9d035af March 3, 2025 14:49
@iFergal iFergal merged commit fc48dd0 into main Mar 3, 2025
1 check passed
@iFergal iFergal deleted the fix/out-order-ipex branch March 3, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants