Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: camera black screen UI #976

Merged
merged 9 commits into from
Mar 3, 2025

Conversation

jimcase
Copy link
Contributor

@jimcase jimcase commented Feb 25, 2025

Description

The logic to avoid the black screen when switching between front and back cameras involves stopping the current scan, setting a transition state, and then restarting the scan once the transition is complete.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Before
After
ScreenRecording_02-27-2025.10-55-03_1.mov

Android

Before
After
android-video_2025-02-27_11-08-56.mp4

@jimcase jimcase self-assigned this Feb 25, 2025
@jimcase jimcase marked this pull request as ready for review February 27, 2025 10:02
@jimcase jimcase requested review from iFergal and sdisalvo-crd and removed request for iFergal February 27, 2025 10:11
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it seems to work fine. No further comments other than that about the color variable.

@jimcase jimcase force-pushed the fix/barcode-scanner-black-screen-switch-camera branch from daaeedb to 20f61db Compare February 27, 2025 16:10
iFergal
iFergal previously approved these changes Feb 27, 2025
sdisalvo-crd
sdisalvo-crd previously approved these changes Feb 28, 2025
iFergal
iFergal previously approved these changes Feb 28, 2025
@jimcase jimcase dismissed stale reviews from iFergal and sdisalvo-crd via 0557d99 March 3, 2025 09:30
@jimcase jimcase force-pushed the fix/barcode-scanner-black-screen-switch-camera branch from 09310e3 to b4d34ed Compare March 3, 2025 12:22
@jimcase jimcase requested a review from obstar March 3, 2025 16:05
Copy link
Contributor

@obstar obstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, all good

@jimcase jimcase merged commit 99fb9cc into main Mar 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants