-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: camera black screen UI #976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimcase
commented
Feb 27, 2025
iFergal
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it seems to work fine. No further comments other than that about the color variable.
daaeedb
to
20f61db
Compare
jimcase
commented
Feb 27, 2025
iFergal
previously approved these changes
Feb 27, 2025
sdisalvo-crd
previously approved these changes
Feb 28, 2025
iFergal
previously approved these changes
Feb 28, 2025
09310e3
to
b4d34ed
Compare
obstar
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, all good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic to avoid the black screen when switching between front and back cameras involves stopping the current scan, setting a transition state, and then restarting the scan once the transition is complete.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Security
Code Review
Design Review
IOS
Before
After
ScreenRecording_02-27-2025.10-55-03_1.mov
Android
Before
After
android-video_2025-02-27_11-08-56.mp4