Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): prevent password hint contain password value #996

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Mar 3, 2025

Description

Disallow storing password in hint

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Prevent hint contain password value
Screen.Recording.2025-03-03.at.13.54.21.mov
Wallet Connection
Screenshot 2025-03-03 at 17 11 05

Android

Wallet Connection

Screenshot_20250303_172132

@Sotatek-DukeVu Sotatek-DukeVu self-assigned this Mar 3, 2025
sdisalvo-crd
sdisalvo-crd previously approved these changes Mar 3, 2025
@sdisalvo-crd sdisalvo-crd requested a review from obstar March 3, 2025 11:44
Copy link
Contributor

@obstar obstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, tested

@sdisalvo-crd sdisalvo-crd merged commit 76ddc31 into main Mar 4, 2025
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feat/DTIS-1939-disallow-storing-password branch March 4, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants