Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Fix flakeys test #997

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Mar 3, 2025

Description

It seem Jest doesn't cleanup JSDOM after each test (maybe only for alert) (jestjs/jest#1224), it make alert 's JSDOM of previous test still exist on current test and jest find duplicate text. Therefore, I was cleaned up JSDOM after the test that use Alert component.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

@sdisalvo-crd sdisalvo-crd merged commit 4fbf741 into main Mar 3, 2025
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feat/DTIS-1915-fix-flakeys-tests branch March 3, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants