feat: transaction statistic status

cardano-foundation · Aug 13, 2024 · 7b4e63f · 7b4e63f
1 parent b8d1c7a
commit 7b4e63f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/...rting_core/resource/presentation_layer_service/AccountingCorePresentationViewService.java b/...rting_core/resource/presentation_layer_service/AccountingCorePresentationViewService.java
@@ -56,7 +56,7 @@ public Optional<TransactionView> transactionDetailSpecific(String transactionId)
 
     public Optional<BatchView> batchDetail(String batchId) {
         return transactionBatchRepositoryGateway.findById(batchId).map(transactionBatchEntity -> {
-                    val transactions = this.getTransaction(transactionBatchEntity);
+                    val transactions = this.getTransactionDispatchStatus(transactionBatchEntity);
                     val statistic = this.getStatistics(transactionBatchEntity.getBatchStatistics());
                     val filteringParameters = this.getFilteringParameters(transactionBatchEntity.getFilteringParameters());
 
@@ -172,7 +172,7 @@ public List<TransactionItemsProcessView> rejectTransactionItems(TransactionItems
                 .toList();
     }
 
-    private Set<TransactionView> getTransaction(TransactionBatchEntity transactionBatchEntity) {
+    private Set<TransactionView> getTransactionDispatchStatus(TransactionBatchEntity transactionBatchEntity) {
         return transactionBatchEntity.getTransactions().stream()
                 .map(this::getTransactionView)
                 .collect(toSet());
@@ -185,7 +185,7 @@ private TransactionView getTransactionView(TransactionEntity transactionEntity)
                 transactionEntity.getEntryDate(),
                 transactionEntity.getTransactionType(),
                 transactionEntity.getStatus(),
-                getTransaction(transactionEntity),
+                getTransactionDispatchStatus(transactionEntity),
                 transactionEntity.getAutomatedValidationStatus(),
                 transactionEntity.getTransactionApproved(),
                 transactionEntity.getLedgerDispatchApproved(),
@@ -196,7 +196,7 @@ private TransactionView getTransactionView(TransactionEntity transactionEntity)
         );
     }
 
-    private LedgerDispatchStatusView getTransaction(TransactionEntity transactionEntity) {
+    private LedgerDispatchStatusView getTransactionDispatchStatus(TransactionEntity transactionEntity) {
         if (ValidationStatus.FAILED == transactionEntity.getAutomatedValidationStatus()) {
             return LedgerDispatchStatusView.INVALID;
         }

diff --git a/...app/accounting_reporting_core/resource/model/AccountingCorePresentationConverterTest.java b/...app/accounting_reporting_core/resource/model/AccountingCorePresentationConverterTest.java
@@ -5,6 +5,7 @@
 import org.cardanofoundation.lob.app.accounting_reporting_core.domain.entity.Violation;
 import org.cardanofoundation.lob.app.accounting_reporting_core.domain.entity.*;
 import org.cardanofoundation.lob.app.accounting_reporting_core.repository.TransactionBatchRepositoryGateway;
+import org.cardanofoundation.lob.app.accounting_reporting_core.resource.requests.LedgerDispatchStatusView;
 import org.cardanofoundation.lob.app.accounting_reporting_core.service.internal.TransactionRepositoryGateway;
 import org.cardanofoundation.lob.app.accounting_reporting_core.resource.presentation_layer_service.AccountingCorePresentationViewService;
 import org.cardanofoundation.lob.app.accounting_reporting_core.resource.requests.BatchSearchRequest;
@@ -109,6 +110,8 @@ void testAllTransactions() {
         assertEquals(Boolean.FALSE, result.get(1).isTransactionApproved());
         assertEquals(Boolean.TRUE, result.get(1).isLedgerDispatchApproved());
         assertEquals(ValidationStatus.FAILED, result.get(1).getValidationStatus());
+        assertEquals(LedgerDispatchStatusView.INVALID, result.get(1).getStatistic());
+        assertEquals(LedgerDispatchStatusView.PENDING, result.get(0).getStatistic());
         assertEquals("tx-id2-internal", result.get(1).getInternalTransactionNumber());
         DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd");
         assertEquals(localDate.format(formatter).toString(), result.get(1).getEntryDate().toString());