fix(ui): Group signing and recovery thresholds should not have defaults #1392
+63
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sotatek-DukeVu
requested review from
sdisalvo-crd
and removed request for
iFergal and
sdisalvo-crd
iFergal
reviewed
Oct 13, 2025
src/ui/pages/SetupGroupProfile/components/InitializeGroup/InitializeGroup.tsx
Outdated
Show resolved
Hide resolved
sdisalvo-crd
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove default value of signing and recovery threshold.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Design Review
Screen.Recording.2025-10-13.at.17.49.40.mov