-
Notifications
You must be signed in to change notification settings - Fork 31
Added Beacon Monitoring. #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will pull this into a separate branch on the CAMS repo so I can improve on the code and docs.
|
Hi @YarnoVdW - I'm looking at the PR now and have some questions... The main question is why the beacon scanning is part of the Bluetooth measure? Why don't we make a separate measure called As it is implemented now, people have to choose between the two using the So - my question is - is there any problem in separating this into two measures, and hence data streams? What is the use case for you? And - are there any technical issues to consider? Can't you scan for BLE devices and beacons at the same time? |
|
|
The other problem is that you're forcing the "old" BLE data model to this beacon data model and mapping almost everything to the beacon name. IMO it would be better to have a dedicated data class for beacons. |
|
@YarnoVdW - if you agree, I can pretty easily fix this by just reshuffling your code. But before doing this, I need to make sure that I understand your use case for this. |
|
@bardram I'll update the code so that you do not have to spend time doing :) It is indeed better to have a dedicated class for the beacon scanning. Our use case is for iOS especially, since iOS does not allow bluetooth scanning while the app is in the background, using iBeacon ranging, we can have our app fully in the background while it is ranging for iBeacons. |
|
Ok. If you can update it that's fine. Ping me when I can review and merge a pull request. |
Added beacon monitoring so that we can scan for beacons close in range to iOS devices in the background.