Modify defensive programming section#451
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/python-intermediate-development/compare/md-outputs..md-outputs-PR-451 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-04-17 14:53:11 +0000 |
* Remove explicit use of np.assert_allclose under pytest.raises * Add Exception message matching to optional exercise
ddfba29 to
3b41928
Compare
anenadic
left a comment
There was a problem hiding this comment.
Looks good to me - thank you @bielsnohr.
Auto-generated via `{sandpaper}`
Source : 6ca5325
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-05-27 09:38:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 1d26a2d
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-05-27 09:38:06 +0000
Message : Merge pull request #451 from carpentries-incubator/bielsnohr/108-check-error-raised
Modify defensive programming section
Auto-generated via `{sandpaper}`
Source : 6ca5325
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-05-27 09:38:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 1d26a2d
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-05-27 09:38:06 +0000
Message : Merge pull request #451 from carpentries-incubator/bielsnohr/108-check-error-raised
Modify defensive programming section
Auto-generated via `{sandpaper}`
Source : 6ca5325
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-05-27 09:38:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 1d26a2d
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-05-27 09:38:06 +0000
Message : Merge pull request #451 from carpentries-incubator/bielsnohr/108-check-error-raised
Modify defensive programming section
Auto-generated via `{sandpaper}`
Source : 6ca5325
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-05-27 09:38:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 1d26a2d
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-05-27 09:38:06 +0000
Message : Merge pull request #451 from carpentries-incubator/bielsnohr/108-check-error-raised
Modify defensive programming section
Auto-generated via `{sandpaper}`
Source : 6ca5325
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-05-27 09:38:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 1d26a2d
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-05-27 09:38:06 +0000
Message : Merge pull request #451 from carpentries-incubator/bielsnohr/108-check-error-raised
Modify defensive programming section
Crucial note: I have not tested this with the project repo code. Not sure when I will get time to do that, but if someone else does have an hour or so to spare, please feel free to verify that the code edits below work.
Closes #108