Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to casbin v2 #10

Merged
merged 4 commits into from
Jan 18, 2024
Merged

feat: upgrade to casbin v2 #10

merged 4 commits into from
Jan 18, 2024

Conversation

msfreed
Copy link
Contributor

@msfreed msfreed commented Jan 17, 2024

Fix: #9

  • Dropped support for netcoreapp3.1 and net5.0
  • Dropped Newtonsoft in favor of System.Text.Json
  • Added support for net8.0
  • Upgraded package references
  • Simplified RedisWatcher and removed the generic version

@casbin-bot
Copy link

@sagilio @AsakusaRinne please review

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hsluoyz
Copy link
Member

hsluoyz commented Jan 18, 2024

@msfreed plz fix CI:

image

@msfreed
Copy link
Contributor Author

msfreed commented Jan 18, 2024

How do you guys feel about only supporting MS supported target frameworks (e.g. net6, net7, net8, netstandard2.1)?

@hsluoyz
Copy link
Member

hsluoyz commented Jan 18, 2024

How do you guys feel about only supporting MS supported target frameworks (e.g. net6, net7, net8, netstandard2.1)?

@msfreed is it easy to keep net5 support? If it's not, it's also OK to upgrade

@hsluoyz
Copy link
Member

hsluoyz commented Jan 18, 2024

@msfreed plz sign CLA

image

@hsluoyz hsluoyz merged commit e604b74 into casbin-net:master Jan 18, 2024
3 checks passed
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@msfreed msfreed deleted the v2-upgrade branch January 18, 2024 14:47
@msfreed
Copy link
Contributor Author

msfreed commented Jan 18, 2024

I've signed a few times, not sure why it isn't recognized yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Latest Casbin.NET Version
5 participants