Merge pull request #14 from NickEntin/entin/infinite-activition-point

Only show activation point when it is inside the snapshotted view
cashapp · Jul 23, 2020 · 036c673 · 036c673
2 parents bec7ed4 + 3966cfc
commit 036c673
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/AccessibilitySnapshot.podspec b/AccessibilitySnapshot.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'AccessibilitySnapshot'
-  s.version          = '0.3.1'
+  s.version          = '0.3.2'
   s.summary          = 'Easy regression testing for iOS accessibility'
 
   s.homepage         = 'https://github.com/CashApp/AccessibilitySnapshot'

diff --git a/AccessibilitySnapshot/Core/Classes/AccessibilitySnapshotView.swift b/AccessibilitySnapshot/Core/Classes/AccessibilitySnapshotView.swift
@@ -164,6 +164,10 @@ public final class AccessibilitySnapshotView: UIView {
                 }
 
             case .always:
+                guard containedView.bounds.contains(marker.activationPoint) else {
+                    break
+                }
+
                 let activationPointView = UIImageView(
                     image: UIImage(named: "Crosshairs", in: Bundle.accessibilitySnapshotResources, compatibleWith: nil)
                 )

diff --git a/Example/Podfile.lock b/Example/Podfile.lock
@@ -1,10 +1,10 @@
 PODS:
-  - AccessibilitySnapshot (0.3.1):
-    - AccessibilitySnapshot/Core (= 0.3.1)
-    - AccessibilitySnapshot/iOSSnapshotTestCase (= 0.3.1)
-  - AccessibilitySnapshot/Core (0.3.1):
+  - AccessibilitySnapshot (0.3.2):
+    - AccessibilitySnapshot/Core (= 0.3.2)
+    - AccessibilitySnapshot/iOSSnapshotTestCase (= 0.3.2)
+  - AccessibilitySnapshot/Core (0.3.2):
     - fishhook (~> 0.2)
-  - AccessibilitySnapshot/iOSSnapshotTestCase (0.3.1):
+  - AccessibilitySnapshot/iOSSnapshotTestCase (0.3.2):
     - AccessibilitySnapshot/Core
     - iOSSnapshotTestCase (~> 6.0)
   - fishhook (0.2)
@@ -31,7 +31,7 @@ EXTERNAL SOURCES:
     :path: "../AccessibilitySnapshot.podspec"
 
 SPEC CHECKSUMS:
-  AccessibilitySnapshot: 5c623007716998e3b9d040fd28f42407c0e38502
+  AccessibilitySnapshot: fc706b52b64780cc00dbadda8b445320ff3ed17c
   fishhook: ea19933abfe8f2f52c55fd8b6e2718467d3ebc89
   iOSSnapshotTestCase: 9ab44cb5aa62b84d31847f40680112e15ec579a6
   Paralayout: e36bf8c795ed9930159b9635ebb802d026667d0b